Skip to content

Name a failed link for what the linker said - #249

Merged
tamnd merged 2 commits into
mainfrom
vdso-ld-overlap
Oct 10, 2026
Merged

tamnd merged 2 commits into
mainfrom
vdso-ld-overlap

Conversation

@tamnd

@tamnd tamnd commented Oct 10, 2026

Copy link
Copy Markdown
Owner

linux-2.6.23 with GCC 3.2.3 on x86_64 fails linking the vDSO, but the cell was unclassified. With binutils 2.14 the linker says ld: section .data [...] overlaps section .plt [...], which has no "error" in it, and make gave up on arch/x86_64/vdso/vdso.so, a target that line doesn't name. So the classifier fell back to the lines kbuild stopped on, which were only a vsyscall-note.S assembler warning from another job.

gave_up_on now falls back to what the linker said when the line before make's give-up is collect2: ld returned 1 exit status and nothing in that block reads as an error. Linker warnings don't count. gcc3-vdso-plt-overlap also matches the binutils 2.14 wording of the overlap.

Checked with a debug build of this branch against the store. Both 2.6.23 x86_64 cells, GCC 3.2.3 and GCC 3.3.6, now explain as gcc3-vdso-plt-overlap. Before this, only the GCC 3.3.6 one did. A new test covers the link case, and all 132 tests pass.

I also tried to confirm binutils-too-old-multiline-macro with binutils 2.19.1 instead of 2.14. 2.6.22's head.S still fails with "missing ')'", and 2.6.23 fails on this same vDSO link, so there's nothing to bisect with GCC 3.2.3.

@tamnd tamnd added this to the G2: the modern history milestone Oct 10, 2026
@tamnd tamnd added kind/bug Something produces a wrong cell, verdict or report area/signatures The failure catalog, classification and bisection platform/x86_64 Tier 1 priority/p2 Should land in the current milestone labels Oct 10, 2026
@tamnd
tamnd merged commit ae93a43 into main Oct 10, 2026
2 of 3 checks passed
@tamnd
tamnd deleted the vdso-ld-overlap branch October 10, 2026 00:58
@tamnd tamnd mentioned this pull request Oct 10, 2026
8 of 15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/signatures The failure catalog, classification and bisection kind/bug Something produces a wrong cell, verdict or report platform/x86_64 Tier 1 priority/p2 Should land in the current milestone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant