Repository navigation
Name a failed link for what the linker said - #249
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
linux-2.6.23 with GCC 3.2.3 on x86_64 fails linking the vDSO, but the cell was unclassified. With binutils 2.14 the linker says
ld: section .data [...] overlaps section .plt [...], which has no "error" in it, and make gave up onarch/x86_64/vdso/vdso.so, a target that line doesn't name. So the classifier fell back to the lines kbuild stopped on, which were only avsyscall-note.Sassembler warning from another job.gave_up_onnow falls back to what the linker said when the line before make's give-up iscollect2: ld returned 1 exit statusand nothing in that block reads as an error. Linker warnings don't count.gcc3-vdso-plt-overlapalso matches the binutils 2.14 wording of the overlap.Checked with a debug build of this branch against the store. Both 2.6.23 x86_64 cells, GCC 3.2.3 and GCC 3.3.6, now explain as
gcc3-vdso-plt-overlap. Before this, only the GCC 3.3.6 one did. A new test covers the link case, and all 132 tests pass.I also tried to confirm
binutils-too-old-multiline-macrowith binutils 2.19.1 instead of 2.14. 2.6.22's head.S still fails with "missing ')'", and 2.6.23 fails on this same vDSO link, so there's nothing to bisect with GCC 3.2.3.