Repository navigation
Conversation
tamnd
added
kind/feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A unit bisection prints only builds or fails for each commit, and it deletes its scratch tree, so a commit where the object fails for some other reason looks the same as one that fails for the reason being bisected. That happened to the bisection of
binutils-too-old-multiline-macro, from 2.6.22 to 2.6.23 with GCC 3.2.3 and binutils 2.14 on x86_64. It reported thatarch/x86_64/kernel/head.ofails at 2.6.23 as well, even though 6e3515352bdd puts the PMDS() call back on one line in v2.6.23-rc4. Nothing was left to show why.unit_rungnow also returns the first line ofunit.log, or ofprepare.logwhen prepare is what failed, that names an error. If no line does, it returns the last line where kbuild says why it stopped. The line is taken before the scratch tree goes, and it is printed under the step, the same way the first error of a whole-cell step already is.New test:
a_failed_unit_says_what_failed. fmt and clippy are clean on server3 and all 131 tests pass.