Repository navigation
Leave a cell the full disk stopped out of the matrix and the reports - #247
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A cell that failed because the build machine ran out of disk says nothing about the kernel or the compiler.
searchalready treats it as not run, but the matrix and the release reports still showed it as a failure. Inreports/new-gcc-16.2.md, for example, 7.2.9 on i386 reads as GCC 16.2 failing at L2, witherror writing to /tmp/ccc2h2gi.s: No space left on deviceas its first error, and 6.12.112 and 7.2.9 on arm64 fail the same way.no_resultin publish.rs names that case, a failed cell for whichbuild::disk_fullholds.matrix()andreport::cells()now leave such cells out. An older cell of the same crossing takes the square if there is one, and otherwise the square reads not run until a search runs the cell again. Cells that went over their budget are left as they were, sinceover-budgetclassifies them and they still count as edges.New test:
a_cell_the_full_disk_stopped_is_no_result. fmt and clippy are clean on server3 and all 130 tests pass.