android: update DNS when default network is changed - #857
Open
kari-ts wants to merge 1 commit into
Open
Conversation
When a new network is detected, we get onAvailable, onCapabilitiesChanged, onLinkPropertiesChanged, and these trigger recomputing and possible updating of the default network. Only onLinkPropertiesChanged updates the dns config, and if the network validation happens after onLinkPropertiesChanged fires, then the cached default network is still on a different network. This refreshes the dns config when a capabilities change causes the selected network to change. Updates tailscale/corp#47631 Signed-off-by: kari-ts <kari@tailscale.com>
cmol
approved these changes
Sep 4, 2026
cmol
left a comment
cmol
left a comment
There was a problem hiding this comment.
Looks good on the surface, though I don't think I am super authoritative on android ATM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a new network is detected, we get onAvailable, onCapabilitiesChanged, onLinkPropertiesChanged, and these trigger recomputing and possible updating of the default network. Only onLinkPropertiesChanged updates the dns config, and if the network validation happens after onLinkPropertiesChanged fires, then the cached default network is still on a different network. This refreshes the dns config when a capabilities change causes the selected network to change.
Updates tailscale/corp#47631