cmd/tailcat: keep --version working as an unadvertised alias - #49
Merged
Conversation
The version subcommand is the documented way to print the version, but nixpkgs' versionCheckHook runs "tailcat --version" and depends on its exit status and output. Rather than advertise both in the global flags, drop the registered --version flag and special-case it in main when parsing fails: print the version and exit zero if os.Args contains --version. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com> Change-Id: Id1a7b23938a546b2f2e49ba2c529b009fe7ef9b0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The version subcommand is the documented way to print the version,
but nixpkgs' versionCheckHook runs "tailcat --version" and depends
on its exit status and output. Rather than advertise both in the
global flags, drop the registered --version flag and special-case
it in main when parsing fails: print the version and exit zero if
os.Args contains --version.