Skip to content

release: print the installed version in the GNU flag form #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guygrigsby merged 1 commit into from
Oct 16, 2026
Merged

release: print the installed version in the GNU flag form #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,4 +81,4 @@ fi
$sudo mkdir -p "$INSTALL_DIR"
$sudo install -m 0755 "$bin" "$INSTALL_DIR/aperture"

echo "==> Installed $("$INSTALL_DIR/aperture" -version | head -1) to $INSTALL_DIR/aperture"
echo "==> Installed $("$INSTALL_DIR/aperture" --version | head -1) to $INSTALL_DIR/aperture"
17 changes: 17 additions & 0 deletions scripts/sign_macos_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,3 +176,20 @@ case "$tool $1" in
;;
esac
`

// install.sh reports the version of what it just installed. It has to use the
// GNU form: the single-dash long form is deprecated, so it both prints a
// deprecation warning on stderr and would greet every fresh install with a
// notice about a flag the user never typed.
func TestInstallScriptReportsVersionInGNUForm(t *testing.T) {
script, err := os.ReadFile("../install.sh")
if err != nil {
t.Fatal(err)
}
if strings.Contains(string(script), " -version") {
t.Error("install.sh calls the installed binary with the deprecated -version form")
}
if !strings.Contains(string(script), `aperture" --version`) {
t.Error("install.sh no longer reports the installed version")
}
}
Loading