Repository navigation
Bump github/codeql-action from 4.39.1 to 4.39.3 - #495
Merged
jacalata merged 2 commits intoNov 10, 2026
Merged
Conversation
* test(e2e): round-trip CSVImport bug coverage for #1811 Adds a two-row CSV fixture and one createsiteusers e2e test exercising every UserItem.CSVImport bug fixed in TSC #1811 (issue #1809): AUTH column readable at 8 columns, mixed-case usernames preserved, TableauIDWithMFA in the auth allowlist, case-insensitive validation of role/admin/publisher tokens, and the @property_is_enum guard active on the parsed auth_setting. Test runs under the same server-admin / site-admin gate as test_users_create_site_users and shares its ordering slot; skips cleanly when the caller lacks admin scope or a credentials file. Related: #297 (license-name case sensitivity still surfacing after partial fixes), #434 (Local auth accepted by the CLI but crashes on TSC call). * test(e2e): pass --no-complete + drop --role Publisher on CSVImport 1811 test `createsiteusers` runs `--complete` by default, which invokes tabcmd's duplicate strict validator (`UserCommand._validate_user_or_throw`). That validator rejects `len(line) > 7` and validates license values case-sensitively -- both of which the CSVImport #1811 fixture is specifically meant to exercise. Under `--complete`, the CSV never reached TSC's `UserItem.CSVImport` and the test fell through tabcmd-side. `--no-complete` skips tabcmd's validator so the fixture reaches TSC's parser. Removing `--role Publisher` lets each row's own license field be validated -- restoring coverage of the case-insensitive-license fix. Also corrected the docstring: five of the six bugs, since the sixth (unknown-AUTH rejection) is a negative-path check that doesn't fit a single happy-path fixture and is already covered by TSC's unit tests. * docs: correct test docstring -- this test doesn't reach TSC's CSVImport yet createsiteusers parses the CSV itself via UserCommand.get_users_from_file() / _parse_line() and builds TSC.UserItem directly; it doesn't delegate to TSC's UserItem.CSVImport. The docstring claimed the opposite. Co-Authored-By: Claude Code <noreply@anthropic.com> * test(e2e): use a valid TSC auth value in the CSVImport fixture TableauID is not a member of TSC.UserItem.Auth in the pinned tableauserverclient (0.42), so the first row raised ValueError before the server call. Use ServerDefault for that row. Co-Authored-By: Claude Code <noreply@anthropic.com> --------- Co-authored-by: Claude Code <noreply@anthropic.com>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.39.1 to 4.39.3. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@v4.39.1...v4.39.3) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.39.3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
jacalata
approved these changes
Nov 10, 2026
jacalata
deleted the
dependabot/github_actions/github/codeql-action-4.39.3
branch
November 10, 2026 00:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps github/codeql-action from 4.39.1 to 4.39.3.
Release notes
Sourced from github/codeql-action's releases.
Changelog
Sourced from github/codeql-action's changelog.
Commits
33d7b85Merge pull request #4299 from github/update-v4.39.3-064910ba224393f8Update changelog for v4.39.3064910bMerge pull request #4297 from github/mbg/update-globf532ac5Updateglobto14.0.38cd4dfaMerge pull request #4280 from github/mbg/ci/validate-yamlcea289bReturn different exit code when a language is not recognised7287bb3Removeexcludeentry that's no longer needed8eb7cdfUse normal.editorconfigpattern160e547Merge remote-tracking branch 'origin/main' into mbg/ci/validate-yaml913e1bbMerge pull request #4283 from github/sam-robson/decode-diff-informed-sarif-urisDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)