Skip to content

Fix review findings in saved-session restore (follow-up to #490) #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jacalata wants to merge 6 commits into
base: development
Choose a base branch
from
Open

Fix review findings in saved-session restore (follow-up to #490) #491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
809039a
Address review findings in session restore and session file handling
jacalata Nov 3, 2026
e0b563f
Follow up session review: auth_token, dead checks, last_command, file…
jacalata Nov 3, 2026
cfef1e6
Handle SystemExit on saved-session paths, avoid double sign-out, isol…
jacalata Nov 3, 2026
07acd91
Fix server URL parsing, logout options, session timeouts, quiet fallb…
jacalata Nov 3, 2026
9fa94e3
Merge origin/development into jac/fix-session-restore-review
jacalata Nov 4, 2026
0e8075f
Restore configured timeout after the saved-session probe
jacalata Nov 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tabcmd/commands/auth/logout_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,8 @@ def run_command(cls, args):
logger = log(cls.__name__, args.logging_level)
logger.debug(_("tabcmd.launching"))
session = Session()
# Session() reconfigures the root logger to INFO, so reapply the requested level
log(cls.__name__, args.logging_level)
# only the connection options; --server and --site must not redirect the saved token
session._update_http_options(args)
session.end_session_and_clear_data()
Loading
Loading