refactor: use datetime/timedelta for exponential backoff elapsed time - #1876
Open
TrueFurina wants to merge 1 commit into
Open
refactor: use datetime/timedelta for exponential backoff elapsed time#1876TrueFurina wants to merge 1 commit into
TrueFurina wants to merge 1 commit into
Conversation
|
Thanks for the contribution! Before we can merge this, we need @TrueFurina to sign the Salesforce Inc. Contributor License Agreement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per #1336 (and the maintainer's suggestion in the thread): swaps the raw
time.time()/ monotonic-elapsed arithmetic intableauserverclient/exponential_backoff.pyfordatetime/timedelta.Changes
tableauserverclient/exponential_backoff.py:self.start_time = time.time()→self.start_time = datetime.now()elapsed = time.time() - self.start_time→elapsed = (datetime.now() - self.start_time).total_seconds()time.sleep(...)retained (sleep still needs seconds)Behavior is unchanged:
elapsedis still a float number of seconds, timeout comparison and error message are identical.Verification
TimeoutErrorwhen the deadline passes (verified locally with a 0.01s timeout)