Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .claude/skills/elfuse-conventions/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -380,6 +380,14 @@ addressed threads with "Resolve conversation"; a reply carries the
correction, the measurement, or nothing. A concise what and why belongs in
the commit body, not the thread.

A reply that hands the choice back to the reviewer is the same artifact in
a politer form. "If you would rather the source read uniformly one way or
the other, say so and I will move the remaining three" asks for an
instruction where a technical answer belongs ("Let's concentrate on real
discussions!", PR#350). A tradeoff already measured is settled in the
reply, with the measurement as the reason. Ask the reviewer a question only
where the code leaves one open.

The body is intent plus reproduction and commands: for a bug, a minimal
reproduction with host macOS and SDK version, hardware, and `make check`
status (PR#21, PR#41); for a performance claim, A/B benchmarks on a named
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,11 @@ State the fact and stop:
- Effort and flattery: "carefully reviewed", "comprehensive", "thoroughly
tested", "Great catch", "You're absolutely right". Effort is not a
finding; name what ran and what it reported.
- Deferral and self-report: an offer to redo the work another way ("say so
and I will", "happy to split this"), an apology for a correction, or an
announcement of candor before a caveat that stands on its own ("worth
flagging rather than hiding"). State the decision and the reason that
settles it; a reviewer who disagrees says so without being invited.
- Formatting as emphasis in docs and PR text: bolded bullet-header runs
where a paragraph belongs, decorative rules, emoji.
- Machine artifacts, defects on sight: zero-width and bidi characters,
Expand Down