Skip to content

Scratch, do not merge: WP7.1b C - #750

Closed
jserv wants to merge 3 commits into
mainfrom
scratch/wp7-c
Closed

jserv wants to merge 3 commits into
mainfrom
scratch/wp7-c

Conversation

@jserv

@jserv jserv commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Temporary CI verification of the mutation condition (scenario C). Not for merge; closed right after its run.


Summary by cubic

Scratch branch that verifies the mutation gating condition (scenario C) in CI. Not for merge.

The mutants job now waits for the gates and the plan before starting, and every cargo mutants command passes --cargo-arg=--locked; a new test suite pins the job's condition and the lockfile flag on all three commands. The docs line is a scratch fixture that changes no Rust, so the plan should find no mutants.

Written for commit 7d58b73. Summary will update on new commits.

View guided diff Turn on auto-fix

A mutation shard rebuilds and runs the whole suite in an unmutated
tree, so when the Rust lane fails the shards fail the same way and
each pays several minutes of setup to learn it. The mutants job
needed only the plan, so it started beside the gates.

Make it need the gates as well, and start only when both the plan
and the gates succeeded and the plan found mutants. The plan result
is checked explicitly because the plan is skipped on a push or a
merge group, where its empty count would otherwise pass the zero
guard. Shards now start after the slowest gates lane. The aggregate
check job already accepts a skipped mutants job after a successful
plan, and a failed gates lane fails it first.

A new suite pins the job's needs and condition.

Change-Id: I994815975efcce27629c6fcfd4a44ae4acb98ebd
The Makefile mutants target passes --cargo-arg=--locked so a mutant is
never judged against a lockfile cargo quietly updated, but the plan's
--list and the shard's --list and run did not, so CI tested against
whatever lock cargo produced and the local and CI answers could differ.

Pass the flag on all three commands and assert in the workflow suite
that each carries it and that the plan and the shard list select with
the same flags and values, so the shard count matches what runs.

Change-Id: I32c942cb8c272fef31dff6829ab6f1419083f54e
Temporary fixture for verifying the CI mutation condition. It edits one
line of prose under docs and changes no Rust file, so the mutants
planner must find nothing. It must not be merged.

Change-Id: Iab2fd81e92c3be7e08d8352973137ca52a4b362a
@jserv jserv closed this Nov 17, 2026
@jserv
jserv deleted the scratch/wp7-c branch November 17, 2026 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant