Repository navigation
Conversation
A mutation shard rebuilds and runs the whole suite in an unmutated tree, so when the Rust lane fails the shards fail the same way and each pays several minutes of setup to learn it. The mutants job needed only the plan, so it started beside the gates. Make it need the gates as well, and start only when both the plan and the gates succeeded and the plan found mutants. The plan result is checked explicitly because the plan is skipped on a push or a merge group, where its empty count would otherwise pass the zero guard. Shards now start after the slowest gates lane. The aggregate check job already accepts a skipped mutants job after a successful plan, and a failed gates lane fails it first. A new suite pins the job's needs and condition. Change-Id: I994815975efcce27629c6fcfd4a44ae4acb98ebd
The Makefile mutants target passes --cargo-arg=--locked so a mutant is never judged against a lockfile cargo quietly updated, but the plan's --list and the shard's --list and run did not, so CI tested against whatever lock cargo produced and the local and CI answers could differ. Pass the flag on all three commands and assert in the workflow suite that each carries it and that the plan and the shard list select with the same flags and values, so the shard count matches what runs. Change-Id: I32c942cb8c272fef31dff6829ab6f1419083f54e
Temporary fixture for verifying the CI mutation condition. It rewrites one conversion in unexpired_state so the mutants planner finds code to mutate. It must not be merged. Change-Id: Ia91144b0010fe0e19d497be36196adcdc409a8e6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary CI verification of the mutation condition (scenario B). Not for merge; closed right after its run.
Summary by cubic
Temporary CI run to verify the mutation-gating changes. Not for merge: the token rewrite in
src/web/auth.rsis a fixture so the mutants planner has code to mutate. The durable workflow change makes mutation shards wait for the gates and locks allcargo mutantsinvocations to the lockfile; the newtest_check_workflow.pypins that shape.Written for commit 4e58242. Summary will update on new commits.