Repository navigation
Conversation
ea5383a to
d817dc1
Compare
d817dc1 to
b2bf4ba
Compare
b2bf4ba to
5d82d8c
Compare
5d82d8c to
13bd3aa
Compare
13bd3aa to
84ad09e
Compare
84ad09e to
4fc35ab
Compare
7315569 to
a80b3ac
Compare
a80b3ac to
9e87421
Compare
5255cdf to
37e2732
Compare
37e2732 to
fff6b89
Compare
fff6b89 to
73e984e
Compare
|
Some review comments on this pull request are not settled yet. Please refine the change per the review comments listed below, reply on each thread with what you changed or why you did not, and mark each thread resolved yourself once it is settled (Resolve conversation, at the bottom of the thread). The pull request stays blocked while review threads are open. Not addressed at the current head:
Checked at 73e984e. |
73e984e to
e18b1b1
Compare
e18b1b1 to
1674ba6
Compare
1674ba6 to
cc77df8
Compare
There was a problem hiding this comment.
Reviewed cc77df8 on Ubuntu with Node.js v22.23.4 and npm 10.9.9.
Baseline validation:
- account.test.js and lobby-render.test.js: 49 passed.
- Filtered pagination-related lobby tests: 12 passed.
- No failures or skips in these runs.
Two inline suggestions strengthen regression coverage:
- Verify the identities of downloaded cross-page reports.
- Verify ordered-list numbering on each page.
For each suggestion, the added assertions passed on the original implementation and failed with the corresponding deliberate mutation. Reproduction details and results are included inline.
No current functional failure was reproduced. The full scripts/test.sh gate was not run. All temporary changes were restored.
Limit visible history without changing filtered totals or batch actions. State the cross-page selection scope and keep pagination locked while report deletion is pending. Restore navigation after both successful and failed deletions. Keep page status concise and describe summary totals as filter matches. Move focus outside history when an empty reload hides the panel. Cover pagination interactions and focus fallbacks with browser tests. Close sysprog21#651 Change-Id: I3f02f5b9eb44aa067682f82383400dd73c60b313
cc77df8 to
8025b84
Compare
Problem and behavior
As candidates accumulate practice attempts, the Past attempts list grows long enough to push the remaining progress information farther down the page. This change paginates the already-loaded, filtered history so candidates can browse 5, 10, or 20 attempts per page without changing the existing attempt order.
Previous and Next expose accessible labels and disabled boundary states, while the page status reports the current and total page count. Pagination is hidden when five or fewer matching attempts fit on one page. Progress summaries continue to use every matching attempt, and report selection and batch downloads continue to include matching attempts on other pages.
Approach
A new
web/attempt-pagination.jsmodule owns the current page, page-size selection, boundary clamping, visible history slice, disabled state, and focus movement.pageAttemptscontains only the rows rendered on the current page, whileshownAttemptsretains the complete filtered collection used by selection and batch download controls.Changing a filter, page size, or history source resets pagination to the first page. Reloading or deleting history retains the current page while it remains valid and otherwise clamps it to the last valid page.
Previous, Next, and the page-size selector remain disabled while report deletion is pending. Their page-boundary states are recalculated after either a successful or failed deletion. When a redraw removes the focused row or pagination control, focus moves to an available target. If empty history hides the entire history section, focus moves to the visible Practice heading outside that section.
The progress summary describes the number of attempts matching the current filters, while the pagination status remains
Page N of M. When matching attempts span multiple pages, the batch controls explicitly state their scope with labels such asDeselect all pagesandDownload selected (N, all pages).Preview
Validation
Added browser coverage for 21 attempts across three pages, 30-attempt account and device histories, page-size changes, filtering from a later page, history reloads, authentication-source changes, cross-page selection and batch downloads, report actions, deletion on the last page, aggregate progress information, empty history, and keyboard focus movement.
Added regression coverage that holds a report deletion request pending and checks that Previous, Next, and the page-size selector remain disabled. The tests cover both successful and failed deletions and verify that navigation is restored afterward.
Ran all three browser shards before the final review amendments; 3169 tests passed and none failed. On the final committed HEAD, nine targeted Chromium tests and two lobby-render tests passed.
Ran
./scripts/test.sh portable; all executed checks passed, including all 337 Git hook checks. One Python test was reported as skipped because the tests ran outside a virtual environment.Ran
./scripts/test.sh rust; all executed tests passed, and the dependency license and source checks passed.Closes #651
Summary by cubic
Paginates the Past attempts list so long attempt histories no longer push remaining progress down the page. Candidates browse 5, 10, or 20 attempts per page without changing attempt order; pagination hides when five or fewer attempts fit one page.
A new
web/attempt-pagination.jsowns the current page, page-size selection, visible slice, and focus movement.shownAttemptskeeps the complete filtered collection so selection and batch downloads cover matching attempts on other pages, with labels like "Select all pages" stating that scope. Pagination resets to page 1 when a filter, page size, or history source changes, clamps to the last valid page after reloads and deletions, and a custom page size reverts to the default on reload. It stays locked while a report deletion is pending or history switches to another account, restoring after success or failure; a failed account switch also drops the old page. Downloads and selection remain locked until the new account's rows land and pagination resets with them, and a row download stays disabled when paging away and back until it completes.Previous/next controls have accessible labels, disabled boundary states, and live page announcements; focus moves before a focused row or control is removed and returns to the page title when an empty reload hides the panel. The status shows
Page N of Mwhile the summary reads "match these filters" across all matching attempts. Browser tests cover pagination across account and device histories, cross-page selection and downloads, pending deletions and downloads, account switches, filter resets, and focus fallbacks.Closes #651.
Written for commit 8025b84. Summary will update on new commits.