Repository navigation
Conversation
Stable Alpine (3.21 to 3.23) packages Verilator for x86-64 only, so the multi-platform push on dev failed with "verilator (no such package)" on linux/arm64. Take verilator and verilator-dev from edge/community on both architectures through an @edge-tagged repository, which keeps every other package on 3.22 and gives both images Verilator 5.050. apk del now uses --no-cache, since without an index it cannot resolve the @edge tag and refuses to commit. Install qemu-x86_64 for firtool once in the base stage instead of in both later stages, and build every platform on pull requests as well, publishing only on push, so a platform-specific break fails before merge.
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The push to dev failed in run 43364358702: the multi-platform "Build and push" step could not install
verilatoron linux/arm64. Stable Alpine (3.21 to 3.23) packages Verilator for x86-64 only; only edge has an aarch64 build.verilatorandverilator-devfrom edge/community on both architectures through an@edge-tagged repository, which keeps every other package on 3.22. Both images get Verilator 5.050 (amd64 moves from 5.036).apk delnow uses--no-cache; without an index it cannot resolve the@edgetag and refuses to commit.qemu-x86_64(firtool on Arm64) once in the base stage instead of in both later stages.Verified locally: the amd64 image passes the CI smoke test offline (four notebooks and the visualizer checks); the arm64 image, built under QEMU, runs native Verilator 5.050, firtool 1.160.0 through qemu-user, and
2.6_chiselsim.ipynboffline.Trade-off: edge packages can be rebuilt without notice, which makes the image less reproducible; CI catches a break. Running the Arm64 smoke test in CI remains open.
Summary by cubic
Fixes the multi-platform Docker build, which failed on linux/arm64 because stable Alpine (3.21–3.23) only packages Verilator for x86-64. The image now installs
verilatorandverilator-devfrom Alpine edge via an@edgetag on both architectures, keeping all other packages on 3.22 and giving both images Verilator 5.050.apk delnow uses--no-cacheso the@edgetag still resolves without an index.qemu-x86_64is installed once in the base stage instead of in both later stages.Trade-off: edge packages can be rebuilt without notice, making the image slightly less reproducible; CI catches a break.
Written for commit 38dd429. Summary will update on new commits.