You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Use exact declared names to color nodes in the visualizer #19
firrtlToDot in source/load-ivy.sc decides whether a node is an input, an output or a register with declaredAs, which accepts a node when it equals a declared name or starts with that name followed by _. That prefix match exists so that the flattened fields of a bundle port (io_in for io.in) are recognised, but it also matches unrelated names. This was reported by the cubic review of #17 and was left out of that PR.
Reproduce with input foo : UInt<8>, node foo_tmp = not(foo) and connect o, foo_tmp: the node foo_tmp is drawn as an input (green circle) because the port foo is declared. The same happens for any wire, node or register whose name begins with the name of a port plus an underscore.
A fix is to record the exact flattened names while the ports and registers are parsed (addPort already walks the bundle fields) and to compare against that set instead of a prefix. It shares the naming problem of #18 (the sanitize collisions), so the two can be fixed together.
Activity
Draw the visualizer from exact FIRRTL references
Draw the visualizer from exact FIRRTL references
Draw the visualizer from exact FIRRTL references
Draw the visualizer from exact references