Skip to content

bug: spending confirm swipe can pay a different amount than the screen #783

Description

@ovitrif

What happened?

On transfer to spending, confirm shows one total. The swipe rebuilds the funding plan and pays that plan. When the rebuilt amount differs from the one on screen, the payment uses the new amount.

This rebuild has been there since #741. Android does the same since synonymdev/bitkit-android#1247, and it can also re-quote the fee rate at swipe. iOS keeps the fee rate that was on screen.

Expected behavior

When the rebuilt amount differs from the amount on screen, the screen shows the new amount and the payment waits for another swipe.

Steps to Reproduce

  1. Open transfer to spending and reach confirm.
  2. Leave it until the funding plan would be rebuilt.
  3. Swipe to pay.
  4. Compare the amount that leaves with the total that was on screen.

Logs / Screenshots / Recordings

N/A

Bitkit Version

2.5.0

Device / OS

iOS. Android has the same rebuild.

Reproducibility

When the plan rebuilt at swipe differs from the plan on screen.

Additional context

Follow-up from the review on #772. The confirm total and the transfer record stay in that PR. The Android discussion is synonymdev/bitkit-android#1323.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

lightningLightning, channels, CJIT, Spending Balance, transfers, or LNURL related

Type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions