test: simplify and extend migration coverage - #258
piotr-iohk wants to merge 6 commits into
Conversation
|
Fresh migration validation runs after the artifact and test fixes: |
|
Replacement iOS migration validation after fixing RN wallet retry isolation: https://github.com/synonymdev/bitkit-ios/actions/runs/36163239073 The earlier iOS run exposed the notification-shade retry issue and was cancelled after the fix was pushed. |
piotr-iohk
left a comment
There was a problem hiding this comment.
QA review
Scope: full PR diff against its merge base, at 92378c9.
No new actionable code findings.
Companions (contract check only, not full twins): android#1347 and ios#804 share branch test/migration-baseline and the new @migration_rn_* / @migration_native_* greps. iOS still calls migration-wallet-setup.yml@main; merge this E2E PR before relying on that reusable workflow’s new wallet-attempt-* artifacts (as documented in the coordinated rollout).
Validation:
- Inspected the full migration matrix/helpers/workflow diff at the pinned head
- Platform selector walk on companion heads for
TotalBalance-primary,SeedContainer,ActivityTagsSubmit,TagsPrompt/Tag-*,NavigationBack, Quickpay intro IDs python3 -m unittest scripts/test_migration_tools.py— 9/9 pass- Confirmed release
2.5.0asset digests matchconfig/migration-checksums.json - Appium migration suite not run (e2e-tests default)
pwltr
left a comment
There was a problem hiding this comment.
Reviewed 92378c9ef2bad1a1d330e6b8b3ad2b1b13453e67, including the migration helpers, retry isolation, artifact layout and workflow contracts with iOS #804 and Android #1347.
No actionable code findings.
The QA review reports 9/9 migration-tooling unit tests passing and matching 2.5.0 release-asset checksums. I have not independently rerun those checks or the Appium migration suite in this posting pass.
The companion iOS manual run passed all four cases on its preceding head. Android's earlier run still has the known rn_restore failure described on #1347, so full rollout verification remains pending.
Merge this PR before the app workflow PRs, because iOS calls the reusable wallet-preparation workflow at @main.
Simplifies routine migration coverage to four cases per platform: React Native 1.1.6 restore and install-on-top, plus previous-native restore and install-on-top. The tests now create both savings and spending history, verify balances and activity after migration and relaunch, and keep passphrase/legacy-address coverage behind the optional extended matrix.
This also adds the reusable Android wallet-preparation workflow required by iOS RN migration, pins native baselines and checksums, and adds archive download/matrix tooling. The refreshed 2.5.0 release artifacts disable geoblocking so hosted US runners can prepare the savings-to-spending state.
Validation:
npx tsc --noEmitCoordinated rollout
This PR is part of one migration-test rollout and should be reviewed with:
Merge the E2E PR first. Before merging the iOS PR, change its reusable wallet-setup workflow reference from the temporary companion branch to
@main. Then merge the Android and iOS workflow PRs.