test: stabilize iOS staging @transfer_1 Home activity asserts - #251
Open
piotr-iohk wants to merge 2 commits into
Open
piotr-iohk wants to merge 2 commits into
piotr-iohk wants to merge 2 commits into
Conversation
iOS staging @transfer_1 raced a delayed Background Payments sheet: tapping ActivitySavings to read Activity-* either timed out under the sheet or landed back on Home, where the transfers were already visible as ActivityShort rows. Wait for those Home rows after each buy and retry the Savings tap only while Home is actually showing. Co-authored-by: piotr-iohk <piotr-iohk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
@transfer_1was failing on iOS staging because the harness opened Savings to readActivity-*after each Blocktank buy. A delayed Background Payments sheet made that the wrong surface. HomeActivityShort-*already showed the transfers — assert those instead, and retry the Savings tap only while Home is actually visible.Failing run
https://github.com/synonymdev/bitkit-ios/actions/runs/35488327247
Job:
e2e-tests-staging - transfer(e2e branchmain)openTransferToSpending→tap('ActivitySavings')timed out at 30s. Screenshot: Background Payments sheet covering Home (Later/Enable).expectSavingsTransferRows(2)waited forActivity-1/2/3. Logs dismissed Background Payments during that wait, then sat on Home. Screenshot: Spending 300000 and two “Transfer from Savings”ActivityShortrows plus the widgets tip. QA reviewed the recording and said the product flow looked fine.Root cause
Harness flake, not a product bug:
ActivitySavings.ActivitySavings+Activity-*. Dismissing the sheet (or a tap that never left Home) leaves the wallet Home list, which usesActivityShort-*. The wait then failed on a successful transfer.Change
test/specs/transfer.e2e.tsonly:ActivityShort-0/ActivityShort-1to showTransferand-while dismissing timed sheets. Same check after channel inspection.openTransferToSpendingretries the Savings tap only while both Home cards are visible, so a delayed sheet no longer burns a single 30s tap.Coverage of “transfer rows appeared after each buy” is kept; it now matches the Home UI that already proved success. A missing transfer row still fails the wait.
Verification
npx eslint test/specs/transfer.e2e.tsnpx tsc --noEmitPlease do not merge until reviewed.