test: match boost_2 RBF activity list (behavior change) - #241
piotr-iohk wants to merge 3 commits into
Conversation
Soften dismissBackgroundPaymentsTimedSheet to a waitForToastBestEffort-style poll so ephemeral intro sheets that already auto-dismissed do not fail send coverage. Matches the same harness change as #234. Co-authored-by: piotr-iohk <piotr-iohk@users.noreply.github.com>
After a successful RBF boost the home list keeps the pending replacement (Sent / Confirms in) and the original send (Removed from Mempool) plus the receive. Stop requiring BoostingIcon / BoostedButton / StatusBoosting on that path. Co-authored-by: piotr-iohk <piotr-iohk@users.noreply.github.com>
|
Closing: this is not an intended RBF behavior change.
That flake shows up on master and on android#1296 (seed paste, unrelated). It is not a product update and should not be papered over in e2e. The Background Payments dismiss from this branch is already on |
TL;DR
BEHAVIOR CHANGE — do not auto-merge. Needs Piotr review.
@boost_2now expects the post-RBF home activity list shown on Android: three short rows, noBoostingIcon. The earlier Background Payments intro soft-dismiss fix stays on this branch.Why
Android product PR synonymdev/bitkit-android#1296 (
fix/896-spread-pasted-seed-words, seed paste — unrelated to this fail) failed 3/3 on local@boost_2:https://github.com/synonymdev/bitkit-android/actions/runs/35523204562
Job:
e2e-tests-local - onchain_boost_receive_widgetsError:
element ("android=new UiSelector().resourceId(\"BoostingIcon\")") still not displayed after 30000msafterBoostSuccessToast.Failure screenshots (attempt 1 and 3, same UI) show three home activity rows and no boosting icon:
-10 422)-10 422)+100 000This is a product/behavior harness update for the RBF activity list, not a flake/timing fix. Same pattern was seen on android#1290 (2026-09-18).
E2E_BRANCHalready resolves to this branch.Change
@boost_2intest/specs/boost.e2e.tsonly (@boost_1CPFP untouched):BoostingIconon the list afterBoostSuccessToast(testID still exists in the app for CPFP /isBoosting(), but it is not rendered on this RBF list).+100 000.ActivityShort-0for the replacement: amount10 000, fee increased, new txid. Assert visible "Confirming" instead ofBoostedButton/StatusBoosting/RBFBoosted(those tags depend onisBoosted, which the list UI shows is false).ActivityShort-1and assertStatusRemoved/ "Removed from Mempool".ActivityShort-0is stillStatusConfirmed.Also on this branch (keep)
Best-effort dismiss of the Background Payments intro sheet (
dismissBackgroundPaymentsTimedSheet), port of #234. That remains so ephemeral intro sheets do not fail send coverage.Test plan
eslint+tsc --noEmitontest/specs/boost.e2e.tse2e-tests-local - onchain_boost_receive_widgetson android#1296 after this lands (no emulator in this environment)