Repository navigation
Conversation
7 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR delegates Bitcoin payment URI validation to the shared core decoder instead of the app-side substring workaround.
Draft: blocked on bitkit-core #151 being merged and released. The current draft intentionally still uses 0.5.18; the dependency bump will follow once the release exists.
Description
bitcoin:text in query metadata is accepted.Merge blockers
bitkit-corein the version catalog to that actual published Android SDK release.Bip21DecodingTest.ktagainst the released SDK. Its duplicate-key cases are expected to fail against 0.5.18; a mocked app test is not proof of native decoder correctness.Out of Scope
Design
N/A — no UI changes.
Preview
N/A — validation only.
QA Notes
Journeys
bip21-core-validation.xml— valid metadata preserves recipient/amount; the original concatenated URI and duplicate parameters cannot open a payment sheet. Not run: requires the released SDK containing Navigation intro buy #151.Manual Tests
message=bitcoin:donationto the system clipboard → return to Home and confirm Read Clipboard → the correct payment opens; repeat with the String formmating error lint #63 malformed URI → no payment opens — arbitrary OS clipboard injection is not in Capabilities.Automated Checks
Bip21DecodingTest.kt— checks the actual Android native decoder using the String formmating error lint #63 fixture, duplicate singleton keys, valid metadata and question marks in notes; device execution is pending the SDK release.AppViewModelSendFlowTest.kt— verifies manual-entry, scanning and clipboard delegation, rejected-payment state clearing, and incoming-payment-request failure feedback.Bip21UrlBuilderTest.kt— replaced by decoder integration coverage; invoice generation tests remain.AppViewModelSendFlowTest.ktpassed on the focused rerun.iOS counterpart: #909.