chore: use `tinyexec` by sacrosanctic · Pull Request #1213 · sveltejs/cli

sacrosanctic · 2026-08-01T11:11:59Z

Closes #

Description

Checklist

Update snapshots (if applicable)
Add a changeset (if applicable)
Allow maintainers to edit this PR
I care about what I'm doing, no matter the tool I use (Notepad, Sublime, VSCode, AI...)

pkg-svelte-dev · 2026-08-01T11:12:02Z

Install the latest version of sv from ea6eb58:

pnpm add https://pkg.svelte.dev/sv/c/ea6eb5884f9b5ad9f04513d02d7ff871c978a8c0

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/cli/pr/1213

Note

This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed.

changeset-bot · 2026-08-01T11:12:02Z

⚠️ No Changeset found

Latest commit: ea6eb58

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

sacrosanctic

Not sure if these are supposed to throw.

sacrosanctic · 2026-08-01T11:13:46Z

 	if (process.platform === 'win32') {
 		// on windows, use taskkill to terminate the process tree
-		await exec('taskkill', ['/PID', `${pid}`, '/T', '/F']);
+		await exec('taskkill', ['/PID', `${pid}`, '/T', '/F'], { throwOnError: true });


i'd wager to say no, it shouldn't throw given that it didn't throw before. im also guessing it exits with a non-zero exit code if the process no longer exists, which we wouldnt want to throw on anyway

sacrosanctic · 2026-08-01T11:13:57Z

@@ -363,7 +363,10 @@ export function createSetupTest(
 			}

 			const installDir = path.resolve(cwd, testName);
-			const install = await exec('pnpm', ['install'], { nodeOptions: { cwd: installDir } });
+			const install = await exec('pnpm', ['install'], {
+				nodeOptions: { cwd: installDir },
+				throwOnError: true


this should not throw since it's being handled in the lines directly underneath it

sacrosanctic · 2026-08-01T11:15:01Z

 import fs from 'node:fs';
 import path from 'node:path';
+import { execSync } from 'tinyexec';


Should be the same

AdrianGonz97 · 2026-08-01T22:38:39Z

+			if (reasons.length === 0) return { success: true, message: undefined };
 			throw new UnsupportedError(reasons);


my old eyes aren't what they used to be - it's easier to read with the spacing :p

Suggested change

if (reasons.length === 0) return { success: true, message: undefined };

throw new UnsupportedError(reasons);

if (reasons.length === 0) {

return { success: true, message: undefined };

}

throw new UnsupportedError(reasons);

AdrianGonz97 · 2026-08-01T22:43:54Z

+		await exec(command, args, { nodeOptions: { cwd }, throwOnError: true });
 		return {};
 	} catch (e) {
 		// @ts-expect-error tinyexec rethrows the spawn error as-is


// @ts-expect-error tinyexec rethrows the spawn error as-is

I know you didn't change this catch-block, but is this still correct? Looking through NonZeroExitError, I don't see e.code as an available prop.

AdrianGonz97 · 2026-08-01T22:45:56Z


 	try {
-		execSync('docker --version', { cwd, stdio: 'pipe' });
+		execSync('docker', ['--version'], { nodeOptions: { cwd } });


this should throw

Suggested change

execSync('docker', ['--version'], { nodeOptions: { cwd } });

execSync('docker', ['--version'], { nodeOptions: { cwd }, throwOnError: true });

AdrianGonz97 · 2026-08-01T22:58:24Z

 	if (process.platform === 'win32') {
 		// on windows, use taskkill to terminate the process tree
-		await exec('taskkill', ['/PID', `${pid}`, '/T', '/F']);
+		await exec('taskkill', ['/PID', `${pid}`, '/T', '/F'], { throwOnError: true });


i'd wager to say no, it shouldn't throw given that it didn't throw before. im also guessing it exits with a non-zero exit code if the process no longer exists, which we wouldnt want to throw on anyway

AdrianGonz97 · 2026-08-01T23:12:14Z

 			fs.writeFileSync(pageServerPath, pageServer, 'utf8');

-			execSync('npm run db:push', { cwd, stdio: 'pipe' });
+			execSync('npm', ['run', 'db:push'], { nodeOptions: { cwd } });


execSync from node:child_process throws by default on non-zero exit codes. it should probably throw here as well

Suggested change

execSync('npm', ['run', 'db:push'], { nodeOptions: { cwd } });

execSync('npm', ['run', 'db:push'], { nodeOptions: { cwd } });

AdrianGonz97 · 2026-08-01T23:12:28Z


 	// Generate auth schema using better-auth CLI
-	execSync('npm run auth:schema', { cwd, stdio: 'pipe' });
+	execSync('npm', ['run', 'auth:schema'], { nodeOptions: { cwd } });


same for this

AdrianGonz97 · 2026-08-01T23:12:33Z


 	// Push schema to DB
-	execSync('npm run db:push -- --force', { cwd, stdio: 'pipe' });
+	execSync('npm', ['run', 'db:push', '--', '--force'], { nodeOptions: { cwd } });


AdrianGonz97 · 2026-08-01T23:13:43Z

 	}

-	if (dockerInstalled) execSync('docker compose up --detach', { cwd, stdio: 'pipe' });
+	if (dockerInstalled) execSync('docker', ['compose', 'up', '--detach'], { nodeOptions: { cwd } });


this one should probably throw (or at least be handled in some way) as well if we're depending on it running successfully

AdrianGonz97 · 2026-08-01T23:16:28Z


 fs.writeFileSync(path.join(test_workspace_dir, 'pnpm-workspace.yaml'), 'packages:\n  - ./*\n');

-const exec_async = promisify(nodeExec);


hmmm, there was a reason we used this instead due to failing tests, but if it's no longer failing then we're probably good

Co-authored-by: CokaKoala <31664583+AdrianGonz97@users.noreply.github.com>

sacrosanctic added 8 commits August 1, 2026 18:47

drop in replacement

fdcf48f

add run helper that defaults cwd to testOutputPath

c791d83

refactor out constructCommand

2115be4

refactor to no throw

1fc25b7

tinyexec doesn't throw by default

21bef99

clean up

d7d20f9

every exec on this page should throw?

696efaa

not sure if this is a one to one refactor

f44f36e

sacrosanctic commented Aug 1, 2026

View reviewed changes

sacrosanctic added 5 commits August 1, 2026 19:15

lint

390a6ea

fix

78030c6

fix

e48f361

nit

20674ce

rerun test

764cf6a

AdrianGonz97 reviewed Aug 1, 2026

View reviewed changes

Update packages/sv/src/core/verifiers.ts

ea6eb58

Co-authored-by: CokaKoala <31664583+AdrianGonz97@users.noreply.github.com>

		if (reasons.length === 0) return { success: true, message: undefined };
		throw new UnsupportedError(reasons);

	execSync('docker', ['--version'], { nodeOptions: { cwd } });
	execSync('docker', ['--version'], { nodeOptions: { cwd }, throwOnError: true });

	execSync('npm', ['run', 'db:push'], { nodeOptions: { cwd } });
	execSync('npm', ['run', 'db:push'], { nodeOptions: { cwd } });


		fs.writeFileSync(path.join(test_workspace_dir, 'pnpm-workspace.yaml'), 'packages:\n - ./*\n');

		const exec_async = promisify(nodeExec);

Uh oh!

Uh oh!

Conversation

sacrosanctic commented Aug 1, 2026

Description

Checklist

Uh oh!

pkg-svelte-dev Bot commented Aug 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Aug 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

sacrosanctic left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AdrianGonz97 Aug 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AdrianGonz97 Aug 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AdrianGonz97 Aug 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pkg-svelte-dev Bot commented Aug 1, 2026 •

edited

Loading

changeset-bot Bot commented Aug 1, 2026 •

edited

Loading

AdrianGonz97 Aug 1, 2026 •

edited

Loading

AdrianGonz97 Aug 1, 2026 •

edited

Loading

AdrianGonz97 Aug 1, 2026 •

edited

Loading