chore: knip informed clean up - #1208
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/sv/c/80e7ca7fd30644512b31baba1cf3336d06023fb1Open in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
|
jycouet
left a comment
jycouet
left a comment
There was a problem hiding this comment.
I like knip a lot, but I'm not sure it's very helpful at the moment here.
Some other views?
BTW, would be good to link issue and/or description to give a little more context.
| { | ||
| "$schema": "https://unpkg.com/knip@6/schema.json", | ||
| "tags": ["-lintignore"], | ||
| "workspaces": { | ||
| ".": { | ||
| "entry": ["scripts/*.js"] | ||
| }, | ||
| "packages/sv-utils": { | ||
| "entry": ["src/index.ts", "src/tests/*.ts"], | ||
| "ignore": ["src/tests/**"] | ||
| }, | ||
| "packages/sv": { | ||
| "entry": [ | ||
| "bin.ts", | ||
| "src/index.ts", | ||
| "src/testing.ts", | ||
| "src/cli/*.ts", | ||
| "src/create/scripts/*.js" | ||
| ], | ||
| "ignore": ["src/**/tests/**", "src/create/templates/**", "src/create/shared/**"] | ||
| }, | ||
| "packages/migrate": { | ||
| "entry": ["migrations/**/index.js"] | ||
| } | ||
| }, | ||
| "ignoreExportsUsedInFile": { "type": true }, | ||
| "ignoreBinaries": ["wait"] | ||
| } |
There was a problem hiding this comment.
Happy to see that it catched only 1 or 2 nitpicks!
It's also because a lot of stuff are ignored, maybe there are more stuff to knip await ^^
There was a problem hiding this comment.
- tests are ignored, but could be refined to just ignore the test output
/templatesand/sharedshouldnt be parsed, they're not actually a part of the project with regards to imports and exports- the last 2 are knip bugs, or they require a lot of refactoring to fix
We don't have to add it, we can just keep the changes it found.
No issue, doing it showcases whether its worth it or not. Also feels pretty self explanatory along the lines of |
2 participants
Closes #
Description
Checklist