fix: complete empty TUS multipart uploads when Upload-Length is 0 - #1365
Closed
hsusul wants to merge 1 commit into
Closed
fix: complete empty TUS multipart uploads when Upload-Length is 0#1365hsusul wants to merge 1 commit into
hsusul wants to merge 1 commit into
Conversation
TUS marks size-0 uploads final without write(), so S3Store.create must finish the empty multipart before onUploadFinish HeadObject runs.
Member
|
Thanks, we need to fix it in upstream, not here. Could you direct your patch there? I can give look for review |
1 task
Contributor
Author
|
Thanks — agreed this belongs upstream. Opened the fix in tus-node-server: tus/tus-node-server#876 Closing this PR in favor of that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upload-Length: 0returned a bare404because TUS treats size-0 as immediately final (nowrite()), while@tus/s3-storecreate()only starts a multipart upload. OuronUploadFinishthenHeadObjects a key that does not exist yet.S3Store.createto call upstreamfinishMultipartUpload(metadata, [])(which already uploads a zero-byte part whenpartsis empty), then complete metadata and clear cache, so the object exists before finish runs.0finalization and that non-zero / deferred sizes are unchanged.Test plan
npm run test:unit -- src/storage/protocols/tus/s3-store.test.tsPOST /storage/v1/upload/resumablewithUpload-Length: 0and validUpload-Metadata→201, object exists as emptyUpload-Length: 1+ PATCH still succeeds