Repository navigation
test(postgrest-typegen): cover the interval to string mapping - #235
Merged
Merged
Conversation
postgres-meta carried this case in its own suite through a direct import of pgTypeToTsType, which it no longer declares as a dependency; the generator's mapping belongs with the generator's tests.
|
Warning Review limit reachedNext included review available in 33 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Tr00d
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes SDK-1972 together with the matching removal in supabase/postgres-meta#1155.
postgres-meta's
test/types.test.tsasserted thatpgTypeToTsTypemapsintervaltostringthrough a direct import of@supabase/postgrest-typegen. After postgres-meta#1155 that package is no longer one of its declared dependencies (it depends on@supabase/typegen, which pins postgrest-typegen), so the import only resolved through npm hoisting. The case moves here, next to the generator it tests, and postgres-meta drops the import.No source change.
bun test,check-typesandformat-and-lintpass.