-
Notifications
You must be signed in to change notification settings - Fork 516
chore(ci): bump the actions-major group across 1 directory with 4 updates #6387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -325,7 +325,7 @@ jobs: | |||||
| # its output file — the step sits idle until the job timeout, discarding | ||||||
| # a completed review (openai/codex-action#150). v1.11 handles the same | ||||||
| # heavy workload cleanly. There is no released fix above v1.12 yet. | ||||||
| uses: openai/codex-action@52fe01ec70a42f454c9d2ebd47598f9fd6893d56 # v1.11 | ||||||
| uses: openai/codex-action@86365089eb2b84e0a8fb0717b304f8bdcb13b20e # v1.12 | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Severity: MEDIUM Changing this security-review invocation to v1.12 enables the known Linux completion regression (upstream issue #150): after Codex writes the output file, the step can run until timeout, so 💡 Fix SuggestionSuggestion: Revert the
Suggested change
|
||||||
| with: | ||||||
| openai-api-key: ${{ secrets.OPENAI_API_KEY }} | ||||||
| prompt-file: .github/ai-review/codex-review-prompt.md | ||||||
|
|
@@ -489,7 +489,7 @@ jobs: | |||||
| # its output file — the step sits idle until the job timeout, discarding | ||||||
| # a completed review (openai/codex-action#150). v1.11 handles the same | ||||||
| # heavy workload cleanly. There is no released fix above v1.12 yet. | ||||||
| uses: openai/codex-action@52fe01ec70a42f454c9d2ebd47598f9fd6893d56 # v1.11 | ||||||
| uses: openai/codex-action@86365089eb2b84e0a8fb0717b304f8bdcb13b20e # v1.12 | ||||||
| with: | ||||||
| openai-api-key: ${{ secrets.OPENAI_API_KEY }} | ||||||
| prompt-file: trusted/.github/ai-review/adjudicate-prompt.md | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For heavy Linux reviews, this restores the exact v1.12 regression that the immediately preceding change fixed: the workflow's own lines 323–327 document upstream issue #150, where Codex writes its output but never returns and the job eventually times out. The same bad upgrade is repeated for adjudication at line 492, so a sufficiently heavy PR can lose both the independent Codex result and the final merged review; retain the v1.11 SHA until a release containing the upstream fix is available.
Useful? React with 👍 / 👎.