Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ai-review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ jobs:
# its output file — the step sits idle until the job timeout, discarding
# a completed review (openai/codex-action#150). v1.11 handles the same
# heavy workload cleanly. There is no released fix above v1.12 yet.
uses: openai/codex-action@52fe01ec70a42f454c9d2ebd47598f9fd6893d56 # v1.11
uses: openai/codex-action@86365089eb2b84e0a8fb0717b304f8bdcb13b20e # v1.12

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep the Codex action pinned below v1.12

For heavy Linux reviews, this restores the exact v1.12 regression that the immediately preceding change fixed: the workflow's own lines 323–327 document upstream issue #150, where Codex writes its output but never returns and the job eventually times out. The same bad upgrade is repeated for adjudication at line 492, so a sufficiently heavy PR can lose both the independent Codex result and the final merged review; retain the v1.11 SHA until a release containing the upstream fix is available.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Severity: MEDIUM

Changing this security-review invocation to v1.12 enables the known Linux completion regression (upstream issue #150): after Codex writes the output file, the step can run until timeout, so post-review never executes. A PR-controlled diff/prompt can trigger this and omit security findings.
Helpful? Add 👍 / 👎

💡 Fix Suggestion

Suggestion: Revert the openai/codex-action pin from v1.12 back to v1.11 by replacing the commit SHA 86365089eb2b84e0a8fb0717b304f8bdcb13b20e with the v1.11 SHA 52fe01ec70a42f454c9d2ebd47598f9fd6893d56. The repository's own inline comments (lines 322-327) explicitly document that v1.12 must NOT be used due to a confirmed completion regression (openai/codex-action#150) where heavy Linux runs hang until job timeout, causing security findings to be silently discarded. This Dependabot bump should be rejected/reverted.

⚠️ Experimental Feature: This code suggestion is automatically generated. Please review carefully.

Suggested change
uses: openai/codex-action@86365089eb2b84e0a8fb0717b304f8bdcb13b20e # v1.12
uses: openai/codex-action@52fe01ec70a42f454c9d2ebd47598f9fd6893d56 # v1.11

with:
openai-api-key: ${{ secrets.OPENAI_API_KEY }}
prompt-file: .github/ai-review/codex-review-prompt.md
Expand Down Expand Up @@ -489,7 +489,7 @@ jobs:
# its output file — the step sits idle until the job timeout, discarding
# a completed review (openai/codex-action#150). v1.11 handles the same
# heavy workload cleanly. There is no released fix above v1.12 yet.
uses: openai/codex-action@52fe01ec70a42f454c9d2ebd47598f9fd6893d56 # v1.11
uses: openai/codex-action@86365089eb2b84e0a8fb0717b304f8bdcb13b20e # v1.12
with:
openai-api-key: ${{ secrets.OPENAI_API_KEY }}
prompt-file: trusted/.github/ai-review/adjudicate-prompt.md
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/cli-go-codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@ff2f1c621b7f889edc0d3c761ac2e6a3f8cdb0dd # v4.37.7
uses: github/codeql-action/init@db488ddef3bf6cb639b32c2e9a7c0a7ea8271d28 # v4.37.8
with:
languages: ${{ matrix.language }}
build-mode: ${{ matrix.build-mode }}
Expand Down Expand Up @@ -95,7 +95,7 @@ jobs:
exit 1

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@ff2f1c621b7f889edc0d3c761ac2e6a3f8cdb0dd # v4.37.7
uses: github/codeql-action/analyze@db488ddef3bf6cb639b32c2e9a7c0a7ea8271d28 # v4.37.8
with:
category: "/language:${{matrix.language}}"
defaults:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release-shared.yml
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,7 @@ jobs:

- name: Sync stable release to Linear
if: ${{ inputs.channel == 'stable' && env.LINEAR_CLI_STABLE_RELEASE_ACCESS_KEY != '' }}
uses: linear/linear-release-action@17b8c24f8ceb2b98cabaf1965ff83c55dd596fac # v0
uses: linear/linear-release-action@0a25abab892a91062ebf42260dbb2ce6277aa205 # v0
with:
access_key: ${{ env.LINEAR_CLI_STABLE_RELEASE_ACCESS_KEY }}
version: v${{ inputs.version }}
Expand All @@ -437,7 +437,7 @@ jobs:

- name: Sync beta release to Linear
if: ${{ inputs.channel == 'beta' && env.LINEAR_CLI_BETA_RELEASE_ACCESS_KEY != '' }}
uses: linear/linear-release-action@17b8c24f8ceb2b98cabaf1965ff83c55dd596fac # v0
uses: linear/linear-release-action@0a25abab892a91062ebf42260dbb2ce6277aa205 # v0
with:
access_key: ${{ env.LINEAR_CLI_BETA_RELEASE_ACCESS_KEY }}
version: v${{ inputs.version }}
Expand Down
Loading