test(stack): qualify complete slim Docker service graph - #6374
Conversation
…3-stack-qualify-the-complete-slim-docker-service-graph
Supabase CLI previewnpx --yes https://pkg.pr.new/supabase/cli/supabase@6755b751660c85cee50ce94f94e447bf4e69ea8fPreview package for commit |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4683e0d172
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…plete-slim-docker-service-graph
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6755b75166
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const remaining = ownedDockerContainers(siblingApiPort).map( | ||
| (container) => container.name, | ||
| ); | ||
| expect(remaining).toEqual([]); |
There was a problem hiding this comment.
When sibling.dispose() rejects or its best-effort Docker cleanup leaves a container behind—the failure this assertion is intended to detect—this block only records the assertion error before deleting the data directory and rethrowing. The leaked container remains on the shared daemon, consuming resources and potentially interfering with concurrently running files; after capturing the remaining exact owned names, force-remove those names as a final best-effort cleanup.
AGENTS.md reference: AGENTS.md:L317-L321
Useful? React with 👍 / 👎.
2 participants
Summary
Context
This is a test-only qualification change for CLI-2113. The existing stack implementation already satisfied the complete Docker graph and sibling-isolation contracts; the new journey makes those release-critical guarantees observable through the public package surface.