Initial draft for metadata factory migration - #259
Open
Amityush-lgtm wants to merge 7 commits into
Open
Conversation
samaloney
reviewed
Aug 4, 2026
| end_time = date_offset + 1 * u.day | ||
|
|
||
| times = start_time + times | ||
| meta = { |
Member
There was a problem hiding this comment.
Should this not use the new MetaData classes you added in the other PR?
Contributor
Author
There was a problem hiding this comment.
My bad, i completely missed that part, ill fix it right away
samaloney
reviewed
Aug 4, 2026
| start_time = Time.strptime(file.stem.split("_")[-1], "%Y%m%d") | ||
| end_time = start_time + 86399 * u.s | ||
| times = start_time + (np.arange(1440) * 60 + 30) * u.s | ||
| meta = { |
Member
There was a problem hiding this comment.
Should this not use the new MetaData classes you added in the other PR?
Amityush-lgtm
marked this pull request as ready for review
August 11, 2026 12:44
Amityush-lgtm
force-pushed
the
metadata-factory
branch
from
August 11, 2026 13:27
6f638fa to
84b421f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
For now, this draft PR starts the metadata factory migration by moving Callisto and WAVES to the new
from_raw()pattern.This is just an initial step to understand the migration, @samaloney and @hayesla Let me know if this looks like the right direction.
Changes:
raw (header, raw_object)pairs for Callisto and WAVES.from_raw()in the instrument classes.AI Assistance Disclosure
AI tools were used for: