Add a BSD 3-Clause license - #53
Merged
Merged
Conversation
The repository had no license, so the default of all rights reserved applied: nobody had permission to use, modify, or redistribute it, even though it is published on PyPI and imported by `esis`. Use the BSD 3-Clause license, matching the rest of the organization. It also satisfies NASA SPD-41a, which asks that software developed with Science Mission Directorate funding be released under a permissive license. Declare it in the package metadata using the PEP 639 fields, so that the built distributions carry `License-Expression: BSD-3-Clause` and ship the `LICENSE` file. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 840 840
=========================================
Hits 840 840
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repository has no license, which means the default of all rights reserved
applies: nobody has permission to use, modify, or redistribute it, even though
it is published on PyPI and imported by
esis. This is the same change mergedacross the rest of the organization: sun-data/regridding#54,
sun-data/named-arrays#203, sun-data/colorsynth#11, sun-data/ndfilters#28,
sun-data/optika#199, sun-data/ctis#24, sun-data/aastex#17,
sun-data/solar-dynamics-observatory#22, and
sun-data/interface-region-imaging-spectrograph#48.
BSD 3-Clause matches
numpyandastropy, which this package sits on top of.It also satisfies NASA SPD-41a, which asks that software developed with Science
Mission Directorate funding be released under a permissive license, and its
third clause forbids using the copyright holders' names to endorse derived
products.
Changes
LICENSE, the standard BSD 3-Clause text, with the copyright lineCopyright (c) 2024-2026, Roy T. Smart and Jacob D. Parker. Those are the twocontributors to this repository, and 2024 is when it was created.
pyproject.tomldeclareslicense = "BSD-3-Clause"andlicense-files = ["LICENSE"], the PEP 639 form.Verified by building a wheel from this branch: the metadata is
Metadata-Version: 2.4withLicense-Expression: BSD-3-ClauseandLicense-File: LICENSE, so PyPI will display it on the next release. There isno
License ::classifier to conflict with the expression.Heads up on the Ruff check
Running
ruff check .locally with ruff 0.16.3 reports one pre-existing errorunrelated to this change,
D100 undocumented-public-moduleindocs/conf.py.This repository sets
preview = trueand selects theDandDOCrule sets,so the effective rules move with the ruff release, and the last Ruff workflow
run here was in June. If the check fails on this pull request, that is why, and
it needs its own fix rather than being folded in here.
Worth knowing before merging
The copyright line names the authors rather than Montana State University.
MSU's faculty handbook gives authors ownership of copyrightable works other
than commissioned courseware, which is the basis for that, but the university
has not been asked, and if it ever asserts ownership the line is an ordinary
commit to correct. Releasing permissively is the part that does not undo:
copies distributed under these terms stay licensed under them.
🤖 Generated with Claude Code