Skip to content

Number the lines of the article by default - #14

Merged
roytsmart merged 1 commit into
mainfrom
document-linenumbers
Aug 18, 2026
Merged

Number the lines of the article by default#14
roytsmart merged 1 commit into
mainfrom
document-linenumbers

Conversation

@roytsmart

Copy link
Copy Markdown
Contributor

Problem

The AAS pre-submission checklist requires that manuscripts include line numbers, so reviewers can refer to specific lines. Nothing in this library did that, and it is the kind of requirement noticed only after the manuscript has been uploaded.

Changes

Document now passes the linenumbers class option by default:

\documentclass[twocolumn,linenumbers]{aastex701}

and takes a linenumbers argument to turn it off, for a version meant to be read rather than reviewed:

aastex.Document(linenumbers=False)

The option is appended to whatever document_options were supplied, accepting either a string or a list, and is not duplicated if it was already present.

Testing

Tests cover the default, the disabled case, and each form of document_options, asserting the option appears exactly once alongside the options given. Also compiled two real documents and confirmed line numbers appear in the text layer of the default one and are absent with linenumbers=False. Suite: 119 passing.

🤖 Generated with Claude Code

https://claude.ai/code/session_01BYjDL98znSud1yFh9chnkP

The AAS pre-submission checklist requires line numbers for review, and
forgetting them is the kind of thing noticed only once the manuscript
has been uploaded.

`Document` now passes the `linenumbers` class option by default, and
takes a `linenumbers` argument to turn it off for a version meant to be
read rather than reviewed. The option is added to whatever
`document_options` were given, whether a string or a list, and is not
repeated if it was already there.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BYjDL98znSud1yFh9chnkP
@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d493b15) to head (d6d545c).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #14   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          642       657   +15     
=========================================
+ Hits           642       657   +15     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@roytsmart
roytsmart merged commit 030986f into main Aug 18, 2026
16 checks passed
@roytsmart
roytsmart deleted the document-linenumbers branch August 18, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant