Number the lines of the article by default - #14
Merged
Conversation
The AAS pre-submission checklist requires line numbers for review, and forgetting them is the kind of thing noticed only once the manuscript has been uploaded. `Document` now passes the `linenumbers` class option by default, and takes a `linenumbers` argument to turn it off for a version meant to be read rather than reviewed. The option is added to whatever `document_options` were given, whether a string or a list, and is not repeated if it was already there. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BYjDL98znSud1yFh9chnkP
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 642 657 +15
=========================================
+ Hits 642 657 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The AAS pre-submission checklist requires that manuscripts include line numbers, so reviewers can refer to specific lines. Nothing in this library did that, and it is the kind of requirement noticed only after the manuscript has been uploaded.
Changes
Documentnow passes thelinenumbersclass option by default:and takes a
linenumbersargument to turn it off, for a version meant to be read rather than reviewed:The option is appended to whatever
document_optionswere supplied, accepting either a string or a list, and is not duplicated if it was already present.Testing
Tests cover the default, the disabled case, and each form of
document_options, asserting the option appears exactly once alongside the options given. Also compiled two real documents and confirmed line numbers appear in the text layer of the default one and are absent withlinenumbers=False. Suite: 119 passing.🤖 Generated with Claude Code
https://claude.ai/code/session_01BYjDL98znSud1yFh9chnkP