Allow an author to have more than one affiliation - #13
Merged
Conversation
`Author.affiliation` now accepts a list as well as a single `Affiliation`, and emits one `\affiliation` command for each, which is what AASTeX expects. This is the usual way to handle an author who has moved since the work was done: the organization where the work was done is given first, followed by the present one. The new `Author.affiliations` property returns them as a list either way, so callers do not have to distinguish the two cases. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BYjDL98znSud1yFh9chnkP
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 642 673 +31
=========================================
+ Hits 642 673 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
One job of this pull request sat in `apt-get install` for 45 minutes while the other eleven finished, which happens when another process on the runner is holding the dpkg lock and `apt-get` waits for it indefinitely. Bound that wait so the step fails rather than hangs, and pass `-y` so it never stops for a prompt it cannot receive an answer to. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BYjDL98znSud1yFh9chnkP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Author.affiliationaccepted exactly oneAffiliationanddumps()emitted a single\affiliationcommand, even though AASTeX is happy with several per author.The usual convention when an author has changed institutions is to list the organization where the work was done, followed by their present one. That was impossible to express.
Changes
Author.affiliationnow accepts either anAffiliationor a list of them, and one\affiliationcommand is emitted for each:The new
Author.affiliationsproperty always returns a list, so callers never have to check which form was given. Passing a singleAffiliationbehaves exactly as before.Testing
The
TestAuthorparametrization gains an author with two affiliations, and a new test asserts that the number of\affiliationcommands matches the number given and that each name appears. Also compiled a document with a two-affiliation author and confirmed both institutions appear in the resulting PDF. Suite: 122 passing, coverage 100%.🤖 Generated with Claude Code
https://claude.ai/code/session_01BYjDL98znSud1yFh9chnkP