feat(core)!: bump substrait to v0.99.0 - #1042
Open
nielspardon wants to merge 1 commit into
Open
Conversation
Adds the new built-in `unbound` type introduced in Substrait v0.99.0: a placeholder for a type that has not yet been bound to a concrete type. It lets a producer serialize the shape of a plan (its relations and the names and ordering of its fields) before the concrete field types are known. A plan containing an unbound type is partially bound and must be bound before execution. Unlike every other type, the unbound type carries no nullability and no parameters, so Type.Unbound.nullable() throws and withNullable() is a no-op. Isthmus and Spark reject unbound types, matching the spec guidance that consumers not supporting partially bound plans should reject them. BREAKING CHANGE: adds Type.Unbound and a new TypeVisitor.visit(Type.Unbound) method that direct TypeVisitor implementors must handle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the
substraitsubmodule to v0.99.0 and implements its one feature — the new built-inunboundtype (substrait-io/substrait#1081).unboundis a placeholder for a type that has not yet been bound to a concrete type. It lets a producer serialize the shape of a plan — its relations and the names and ordering of its fields — before the concrete field types are known; a downstream binder fills them in before execution. A plan that contains anunboundtype anywhere within it is partially bound.Changes
Type.Unbound), repackages the extension YAMLs (the oldextensions/unknown.yamlplaceholder is dropped upstream), and addsUNBOUNDto the dialect schema.Type.UnboundPOJO, wired throughTypeVisitorand both proto converters (TypeProtoConverter/ProtoTypeConverter), plus the remaining directTypeVisitorimplementors (StringTypeVisitor,NamedFieldCountingTypeVisitor, Isthmus/SparkIgnoreNullableAndParameters, examplesTypeStringify).TypeKind.UNBOUNDadded to the dialect model for parity with the updated dialect schema.Type.Unboundproto round-trip, and aNamedScanwhose schema carries unbound field types (the partially-bound-plan use case).A note on nullability
Unlike every other Substrait type,
unbound's proto message is empty: it carries no nullability and no parameters (both are determined only when it is bound). SoType.Unbound.nullable()throwsUnsupportedOperationExceptionandwithNullable()is a no-op, rather than falsely reporting the type as non-nullable. Isthmus and Spark reject unbound types — their type visitors inherit the throwing default — matching the spec guidance that consumers which do not support partially bound plans should reject them.Closes #1038
BREAKING CHANGE: adds
Type.Unboundand a newTypeVisitor.visit(Type.Unbound)method that directTypeVisitorimplementors must handle.🤖 Generated with AI