feat(isthmus): observe scalar function types - #1015
Open
alexandrefimov wants to merge 1 commit into
Open
Conversation
Member
Member
|
Did a quick pass and the direciton seems reasonable overall. Planning on taking a closer look tomorrow. |
vbarua
reviewed
Jul 23, 2026
vbarua
reviewed
Jul 23, 2026
vbarua
left a comment
Member
There was a problem hiding this comment.
Left some minor comments, but looks good overall.
Author
|
Thanks for the review! |
Member
|
CONCAT simplification is merged 🙂 |
Assisted-by: gpt-5.6-sol (OpenAI Codex)
alexandrefimov
force-pushed
the
issue-379-scalar-type-observer
branch
from
July 27, 2026 08:49
bca194f to
ebbfe8a
Compare
Author
|
@vbarua rebased on main and addressed all review comments. Ready for another look when you have a chance. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConverterProviderwhile keeping the default conversion path unchangedRelated to #379.
Behavior
RexNodecontinues to use the type supplied by SubstraitCONCATproduces one observation for the complete invocationThis PR intentionally covers scalar functions only. Window functions, field references, and aggregate functions remain separate follow-up work.
Validation
./gradlew build --rerun-tasksCONCATAssisted-by: gpt-5.6-sol (OpenAI Codex)