Skip to content

Fix STATION function names in SU2_PY: SU2_GEO numbers stations from 1 - #2934

Open
nikita-ageev wants to merge 2 commits into
su2code:developfrom
nikita-ageev:fix/geo-station-names
Open

nikita-ageev wants to merge 2 commits into
su2code:developfrom
nikita-ageev:fix/geo-station-names

Conversation

@nikita-ageev

@nikita-ageev nikita-ageev commented Sep 28, 2026 •

Copy link
Copy Markdown

SU2_GEO writes STATION1_* ... STATIONn_* for the stations in GEO_LOCATION_STATIONS, while optnames_geo listed STATION0_* ... STATION19_. STATION20_ was therefore rejected by SU2.eval.func/grad as an unknown function name, and STATION0_* is never written.

Proposed Changes

Give a brief overview of your contribution here in a few sentences.

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary. — Not necessary: no numerical change; existing station constraints (STATION1_* ... STATION5_) in shape_opt_euler_py are unaffected, and the reproduction above covers STATION20_.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary. — config_template.cfg: documented the 1-based STATION numbering (1 to 20).

SU2_GEO writes STATION1_* ... STATIONn_* for the stations in
GEO_LOCATION_STATIONS, while optnames_geo listed STATION0_* ... STATION19_*.
STATION20_* was therefore rejected by SU2.eval.func/grad as an unknown
function name, and STATION0_* is never written.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant