Skip to content

Fix the RAMP_* deprecation messages - #2921

Closed
ManasBagul23 wants to merge 1 commit into
su2code:developfrom
ManasBagul23:fix-deprecation-messages
Closed

ManasBagul23 wants to merge 1 commit into
su2code:developfrom
ManasBagul23:fix-deprecation-messages

Conversation

@ManasBagul23

Copy link
Copy Markdown

Proposed Changes

Fixes the spelling ("deprectaed") of the messages for RAMP_OUTLET_PRESSURE, RAMP_OUTLET_PRESSURE_COEFF, RAMP_ROTATION_FRAME and RAMP_ROTATION_FRAME_COEFF and ends them with a full stop and a blank line like the other deprecation messages, so the next error is no longer printed on the same line.

Before:

RAMP_OUTLET_PRESSURE is deprectaed. Use RAMP_OUTLET insteadLine 97 RAMP_ROTATION_FRAME: invalid option name. Check current SU2 options in config_template.cfg.

After:

Line 96 RAMP_OUTLET_PRESSURE: invalid option name. Check current SU2 options in config_template.cfg.
RAMP_OUTLET_PRESSURE is deprecated. Use RAMP_OUTLET instead.

Line 97 RAMP_ROTATION_FRAME: invalid option name. Check current SU2 options in config_template.cfg.
RAMP_ROTATION_FRAME is deprecated. Use RAMP_MOTION_FRAME instead.

Related Work

Closes #2919.

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

Correct the spelling of "deprecated" and end the messages like the other
deprecation messages, so the following error starts on a new line.
Copilot AI lite review requested due to automatic review settings September 18, 2026 16:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@bigfooted bigfooted closed this Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants