Skip to content

fix: handle(_:) がパスの短い URL で Index out of range になる問題を修正 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
masaru87 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

fix: handle(_:) がパスの短い URL で Index out of range になる問題を修正 #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Lib/StudyplusSDK/Studyplus.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,11 @@ final public class Studyplus {

switch url.pathComponents[1] {
case "success":
guard url.pathComponents.count >= 3 else {
delegate?.studyplusLoginFail(error: .unknownUrl(url))
return false
}

let accessToken: Data = url
.pathComponents[2]
.trimmingCharacters(in: .whitespacesAndNewlines)
Expand Down Expand Up @@ -184,7 +189,8 @@ final public class Studyplus {
guard let scheme = url.scheme else { return false }
guard scheme == "studyplus-\(consumerKey)" else { return false }

if url.pathComponents.isEmpty {
// handle(_:) reads pathComponents[1], so at least 2 components are required
if url.pathComponents.count < 2 {
return false
}

Expand Down