Add cloud provider event parsing methods#2256
Draft
xavdid wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Stripe events have supported AWS EventBridge and Azure Event Grid for a while, but the SDK hasn't paved that path well.
Our webhook parsing logic is closely tied to signature validation, which isn't relevant for events from cloud providers (which don't need to be validated). So, we needed matching non-validating webhook parsing methods.
But we didn't want non-provider event destination users using them (they should still validate events!), so we parse at the payload level to detect whether it looks like a cloud-provider hook and error if not.
Now, users of cloud-based event providers will be able to parse those event bodies and use both Snapshot and Thin events without much trouble.
What?
See Also