Added operand deployment verification to install script - #17
Merged
Conversation
Signed-off-by: Thomas Cooper <code@tomcooper.dev>
MikeEdgar
reviewed
Jul 24, 2026
…nning) Signed-off-by: Thomas Cooper <code@tomcooper.dev>
MikeEdgar
approved these changes
Jul 24, 2026
MikeEdgar
left a comment
MikeEdgar
left a comment
Member
There was a problem hiding this comment.
I haven't had a chance to run it, but the code looks good 👍 Thanks
Member
Author
|
Thanks @MikeEdgar I have run it locally and the smoke-tests will double check in the CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds operand deployment validation to the installations script.
Previously, the script would end after the operands were deployed, leaving the user with manual validation steps. If the user didn't follow them they would try and run the port-forward to access the console and it would usually fail as the Kafka Cluster wasn't actually ready.
Now the script will block until all the components are up and running, so the user has confidence that the stack should be functional.