feat: 馃幐 improve FS(A) error handling - #1297
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
馃煛 Changes recommended
Stream cleanup, close-callback propagation, and autoClose: false behavior need correction.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Improves error propagation and cleanup handling for FSA-backed read/write streams.
Changes:
- Updates asynchronous open and close error handling.
- Adjusts automatic descriptor cleanup.
- Adds regression tests for stream failures and cleanup.
| File | Summary |
|---|---|
packages/鈥媐s-fsa-to-node/鈥媠rc/鈥婩saNodeWriteStream.ts |
Updates deferred-open and close error handling. |
packages/鈥媐s-fsa-to-node/鈥媠rc/鈥婩saNodeReadStream.ts |
Propagates deferred-open failures. |
packages/鈥媐s-fsa-to-node/鈥媠rc/鈥婩saNodeFs.ts |
Updates automatic descriptor cleanup. |
packages/鈥媐s-fsa-to-node/鈥媠rc/鈥媉_tests__/鈥婩saNodeFs.test.ts |
Adds regression coverage for stream failures. |
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.