Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Closes #1490
Changes proposed
managers/process_manager/config_mixin.py, added a check inget_runtime_disabled_modules()to verifyvt_api_key_file. If the key file is not specified, does not exist, cannot be read, or contains an empty key,Modules.VIRUSTOTALis added toruntime_disabled_modules. This prevents Slips from spawning an unnecessary background process for VirusTotal when no valid API key is present.test_config_mixin.pyexpectations and added parametrized unit tests (test_virustotal_disabled_without_api_key) covering valid, empty, and missing key scenarios.Steps I followed to test the changes purposed in this PR:
python3 -m pytest tests/unit/managers/process_manager/test_config_mixin.py(41 passed).Check List
Note to reviewers
Fixes #1490 by checking the API key availability during ProcessManager runtime module resolution, preventing the process from starting when unconfigured.
I have tried my best ,if there is anything wrong or needs to be better please tell!!