Repository navigation
test: register empty_pipeline_stage_no_panic - #152
Merged
ferdingler merged 1 commit intoOct 16, 2026
Merged
ferdingler merged 1 commit into
ferdingler merged 1 commit into
Conversation
The #[test] attribute sat at the end of the section-divider comment above the function, so the test was never registered and the compiler reported the function as dead code. Move the attribute onto its own line.
zastrowm
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
tests/shell_integration.rs, the#[test]attribute ofempty_pipeline_stage_no_panicis at the end of the section-divider comment above the function:Because of this, the test is never registered and never runs. The compiler reports the function as dead code (
function empty_pipeline_stage_no_panic is never used).This PR moves
#[test]onto its own line, the same as the other sections in the file. No other change.Related Issues
None.
Documentation PR
None.
Type of Change
Bug fix (test was not registered)
Testing
cargo test --test shell_integration empty_pipeline_stage_no_panic -- --exact: the test is now listed and passes (1 passed).cargo test --workspace --all-targets: 1806 passed, 0 failed, 0 ignored.cargo clippy --workspace --all-targets: warnings go from 14 to 13. Thedead_codewarning for this function is gone. No new warnings.cargo fmt --check: clean.Not run: Python and Node binding tests (no binding code changed).
cargo test --workspace --all-targets,pytest tests/python,npm test)cargo fmtandcargo clippyChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.