Skip to content

test: register empty_pipeline_stage_no_panic - #152

Merged
ferdingler merged 1 commit into
strands-agents:mainfrom
ferdingler:test/register-empty-pipeline-stage
Oct 16, 2026
Merged

ferdingler merged 1 commit into
strands-agents:mainfrom
ferdingler:test/register-empty-pipeline-stage

Conversation

@ferdingler

@ferdingler ferdingler commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Description

In tests/shell_integration.rs, the #[test] attribute of empty_pipeline_stage_no_panic is at the end of the section-divider comment above the function:

// ── empty pipeline stage does not panic ───────────────────────────#[test]
fn empty_pipeline_stage_no_panic() {

Because of this, the test is never registered and never runs. The compiler reports the function as dead code (function empty_pipeline_stage_no_panic is never used).

This PR moves #[test] onto its own line, the same as the other sections in the file. No other change.

Related Issues

None.

Documentation PR

None.

Type of Change

Bug fix (test was not registered)

Testing

  • cargo test --test shell_integration empty_pipeline_stage_no_panic -- --exact: the test is now listed and passes (1 passed).
  • cargo test --workspace --all-targets: 1806 passed, 0 failed, 0 ignored.
  • cargo clippy --workspace --all-targets: warnings go from 14 to 13. The dead_code warning for this function is gone. No new warnings.
  • cargo fmt --check: clean.

Not run: Python and Node binding tests (no binding code changed).

  • I ran the relevant test suites for the bindings I touched (cargo test --workspace --all-targets, pytest tests/python, npm test)
  • If I touched Rust, I ran cargo fmt and cargo clippy

Checklist

  • I have read the CONTRIBUTING document
  • I have reviewed and understand every line of code in this PR, including any generated by AI tools, and I can explain why it works
  • My change is focused and reasonably small; I have split unrelated work into separate PRs
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly (not applicable)
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The #[test] attribute sat at the end of the section-divider comment
above the function, so the test was never registered and the compiler
reported the function as dead code. Move the attribute onto its own line.
@ferdingler
ferdingler requested a review from a team as a code owner October 16, 2026 12:33
@ferdingler
ferdingler merged commit 76bd346 into strands-agents:main Oct 16, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants