Skip to content

docs(skills): tighten cut-release resume flow - #172

Closed
stozo04 wants to merge 2 commits into
mainfrom
docs/cut-release-feedback
Closed

docs(skills): tighten cut-release resume flow#172
stozo04 wants to merge 2 commits into
mainfrom
docs/cut-release-feedback

Conversation

@stozo04

@stozo04 stozo04 commented Sep 4, 2026

Copy link
Copy Markdown
Owner

Summary

  • Load release references only when the detected stage needs them, so post-merge resumes do not repeat the PR gate.
  • Resolve the build SHA from the final explicitly included merged PR and stop for clarification when newer merges make the release cutoff ambiguous.
  • Handle GitHub issue/PR number confusion explicitly and verify the intended version at the selected SHA.
  • Keep the Claude, Cursor, and Codex skill copies byte-identical.

Verification

  • Skill validator: PASS
  • Harness sync: PASS (46 files x 3 harnesses); all three cut-release SKILL.md files have the same SHA-256.
  • pre-pr-sweep.ps1 -DocsOnly -SkipInspectCode: GREEN for 7c4034e.
  • Markdown lint: 194 files, 0 findings.
  • Link check: 3 changed files, 0 dead links.
  • CSpell: 466 files, 0 unknown words.
  • Script self-checks, JSON, dictionary sync, and Gitleaks: PASS.

Inspect Code was skipped because no Android Studio export was available and this PR changes only skill Markdown. Product builds, emulator verification, and onboarding were skipped by the DocsOnly gate.


Note

Low Risk
Documentation-only changes to agent skill Markdown; no app, script, or release pipeline code changes.

Overview
Updates the cut-release skill (identical copies under .claude, .codex, and .cursor) so resuming a Play release is stage-aware and less error-prone when main moves after the version-bump PR merges.

Stage detection now treats version history and GitHub PR data as authoritative (not chore/release-* branch names), adds handling for an unmerged local bump, and requires correcting mistaken issue numbers vs PR numbers. Ground-truth docs are loaded only when the current step needs them—especially skipping pre-pr-sweep on post-merge resume.

Build SHA replaces the old “bump merge commit only” rule: after merge, the skill must pick the final included merged PR (owner-named cutoff or explicit ask), verify app/build.gradle.kts at that SHA, build/tag/notes from that point, and persist it in releases/openloop-<version>-<code>.buildsha for Stop B / Step 7 resume.

Reviewed by Cursor Bugbot for commit f4c57cd. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

Fix All in Cursor

Bugbot Autofix prepared fixes for both issues found in the latest run.

  • ✅ Fixed: Stop B resume loses build sha
    • Added buildSha sidecar file written at Step 4 and read at Step 7 to preserve the exact commit that built the AAB across resume.
  • ✅ Fixed: Resume misses unmerged bump work
    • Added detection step 7 to handle versionName > latest tag with no bump PR, resuming at Step 2 instead of stalling.

You can send follow-ups to the cloud agent here.

Reviewed by Cursor Bugbot for commit 7c4034e. Configure here.

Comment thread .claude/skills/cut-release/SKILL.md
Comment thread .claude/skills/cut-release/SKILL.md
… bump commits

Fixes two bugs in the cut-release skill:

1. Stop B resume loses build sha (medium severity): Detection step 5 now
   mentions the buildSha sidecar file. Step 4 writes buildSha to
   releases/openloop-<version>-<code>.buildsha when building. Step 7 reads
   from this file to ensure the tag points to the same commit that built
   the AAB, even after resuming.

2. Resume misses unmerged bump work (low severity): Added new detection
   step 7 to handle versionName > latest tag with no bump PR. This case
   (Step 1 completed but PR not yet created) now resumes at Step 2
   (sweep + create PR) instead of stalling or re-bumping.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants