fix(mdm): show telemetry-upload lines in downloaded logs; stop double-capturing Claude Desktop#168
Merged
ashishkurmi merged 2 commits intoJul 17, 2026
Conversation
shubham-stepsecurity
force-pushed
the
sm/dmg-download-logs
branch
from
July 15, 2026 05:29
cc060a4 to
1144abb
Compare
Member
|
@shubham-stepsecurity please compare the changes with #166 |
There was a problem hiding this comment.
Pull request overview
This PR updates enterprise telemetry so the downloadable execution_logs embedded in the uploaded payload include the final “telemetry upload” intent lines, and removes Claude Desktop from IDE detection to avoid reporting it twice (as both an IDE and an AI agent).
Changes:
- Rebuilds the telemetry payload right before the S3 PUT to re-snapshot captured stderr output after logging upload-related progress lines.
- Adds
LogCapture.Sync()with an in-band marker so a snapshot can reliably include the most recently written stderr output without stopping capture. - Removes Claude Desktop from the IDE catalog and updates IDE detector tests accordingly.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/telemetry/telemetry.go | Passes LogCapture into uploadToS3 and re-snapshots execution logs just before upload. |
| internal/telemetry/telemetry_test.go | Updates uploadToS3 call sites for the new capture parameter. |
| internal/telemetry/logcapture.go | Implements Sync() using a stripped in-band marker to flush the async tee into the ring buffer. |
| internal/telemetry/logcapture_test.go | Adds tests validating Sync() flush behavior and marker non-leakage. |
| internal/detector/ide.go | Removes Claude Desktop from IDE detection definitions. |
| internal/detector/ide_test.go | Updates tests to stop asserting Claude-as-IDE and adds a “not an IDE” regression test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shubham-stepsecurity
force-pushed
the
sm/dmg-download-logs
branch
from
July 16, 2026 21:15
1144abb to
d480804
Compare
shubham-stepsecurity
force-pushed
the
sm/dmg-download-logs
branch
from
July 17, 2026 04:46
d480804 to
9be280e
Compare
ashishkurmi
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change
Testing
./stepsecurity-dev-machine-guard --verbose./stepsecurity-dev-machine-guard --json | python3 -m json.toolmake lintmake testRelated Issues