SEP-41: permit additional event topics - #1994
Draft
leighmcculloch wants to merge 5 commits into
Draft
Conversation
|
👋 Thanks for your contribution! This PR proposes changes to the following existing SEP(s):
Per the SEP Contribution Process, changes to an existing SEP should start as a discussion, and should be advocated with the SEP's author(s) — the author maintains the proposal, so engaging them is an important part of getting a change adopted. If you haven't already, please raise your proposed change on the SEP's existing discussion linked above, or start one on the GitHub discussion forum. I have marked this PR as a draft for now. Once the change has been discussed and is ready for a maintainer to review and merge, mark it as ready for review. Thanks for helping improve the Stellar ecosystem! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Clarify that SEP-41 token implementers may emit additional topics beyond those defined, and recommend that any such extension be standardized in its own SEP for interoperability.
Why
The spec was silent on whether implementers could extend events with extra topics, leaving consumers uncertain about what to expect and discouraging interoperable extensions. Whilst I always took this to be an assumption in the ecosystem for any contract SEP, it's become apparent in conversations that was not their assumption. SEP-41 is an important enough standard this should be documented explicitly.
Note that this is not changed behaviour, but rather capturing existing behaviour already playing out in the ecosystem.
Discussion