Skip to content

build: pin @kaciras/deasync to 1.1.0 - #16328

Merged
Planeshifter merged 2 commits into
stdlib-js:developfrom
AryanSharma48:fix-ci-deasync
Oct 28, 2026
Merged

Planeshifter merged 2 commits into
stdlib-js:developfrom
AryanSharma48:fix-ci-deasync

Conversation

@AryanSharma48

@AryanSharma48 AryanSharma48 commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Description

What is the purpose of this pull request?

This pull request:

  • Pins @kaciras/deasync strictly to 1.1.0 in package.json and etc/npm/deps.txt. Recently, version 1.2.0 was published upstream with a missing binding.gyp file, causing make install-node-modules to fail globally across all PRs. This PR removes the caret (^1.0.1) to act as a hotfix and unblock all CI pipelines.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • None

Reference Packages

Did the content of this pull request follow one or more existing packages? Answering is optional.

This pull request followed these packages:

  • None

What carried over from the reference(s)?

  • N/A

What differed, or what did you have to work out yourself?

  • N/A

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Once the upstream package publishes a working patch, we can revert this and restore the caret range.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

I consulted LLMs to analyze the global CI failure logs, inspect the repository's dependency tree, and trace the issue back to the newly published @kaciras/deasync@1.2.0 upstream release. Codex updated the dependency pins to 1.1.0 and corrected the PR title and description to identify 1.2.0 as the broken release.


@stdlib-js/reviewers

Signed-off-by: Aryan Sharma <aryansharma24106@gmail.com>
@AryanSharma48
AryanSharma48 requested a review from a team October 27, 2026 11:56
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Oct 27, 2026
@socket-security

socket-security Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​kaciras/​deasync@​1.2.0 ⏵ 1.1.084100100 +280 -6100

View full report

Planeshifter pushed a commit that referenced this pull request Oct 27, 2026
Ports the fix from #16328 to resolve the CI dependency installation failure (`binding.gyp not found` when building `@kaciras/deasync`). No-op once the base branch carries the same change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017wWD7ArgTRGJD2J6DitJ2W
Planeshifter pushed a commit that referenced this pull request Oct 27, 2026
Ports the fix from #16328 to resolve the CI dependency installation failure (`binding.gyp not found` when building `@kaciras/deasync`). No-op once the base branch carries the same change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017wWD78YjA2bMx3817c7htZ
Planeshifter pushed a commit that referenced this pull request Oct 27, 2026
Port of #16328. CI `npm install` currently fails building `@kaciras/deasync` (`binding.gyp not found`), breaking `Lint PR title` and other install-dependent jobs. This change no-ops once the base branch carries the same pin.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017wWD77jkABgfoQzdCbeSyY
@Planeshifter Planeshifter changed the title build: pin @kaciras/deasync to 1.0.4 build: pin @kaciras/deasync to 1.1.0 Oct 28, 2026
@Planeshifter Planeshifter changed the title build: pin @kaciras/deasync to 1.1.0 build: pin @kaciras/deasync to 1.1.0 Oct 28, 2026

@Planeshifter Planeshifter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Pinning to 1.1.0 since that version was published more than two years ago. Broken release is 1.2.0.

Filed an issue to get this fixed upstream in the dependency: Kaciras/deasync#1

@Planeshifter
Planeshifter merged commit e268fe1 into stdlib-js:develop Oct 28, 2026
19 checks passed
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants