Skip to content

Simplify init_prepare - #267

Draft
Sahel13 wants to merge 3 commits into
mainfrom
simplify-init-prepare
Draft

Simplify init_prepare#267
Sahel13 wants to merge 3 commits into
mainfrom
simplify-init-prepare

Conversation

@Sahel13

@Sahel13 Sahel13 commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

As discussed in #266

@SamDuffield Thoughts on the changes to init_prepare for Kalman?

@SamDuffield

Copy link
Copy Markdown
Contributor

My initial thought is I'm sure I like this as it means the user would have to rebuild the filter if m0 and chol_P0 changed, but I guess that's ok (it's what we do anyway in the EM example)

I like that we remove model_inputs from init_prepare as it makes it clear the user should never expect a non-dummy model_inputs at the initial state.

So overall happy to go with this, although maybe good to confirm with @AdrienCorenflos too as it's an API breaking change

@SamDuffield SamDuffield added the refactor Modify the API (for good reason) label Aug 12, 2026
@AdrienCorenflos

Copy link
Copy Markdown
Contributor

Ok, I've gone back and forth on that one, but I think this is a good change and closer to original design. I'm still not 100% sure (need to see some eventual calls) but I'm confident enough it will be the right move.

@SamDuffield

Copy link
Copy Markdown
Contributor

Okkk let's go ahead and draft the changes required to remove model_inputs from init_prepare!

@SamDuffield
SamDuffield added this pull request to stack #278 September 9, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Modify the API (for good reason)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants