[6.x] Improve the UX of taggable comboboxes - #15249
Open
duncanmcclean wants to merge 6 commits into
Open
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146FsnrtqFd6RhsnrEDf7Fy
…isible The trigger and the input were both tabbable, so it took two presses of the tab key to reach the input. The search query now only resets when the dropdown closes, so a keystroke that opens the dropdown is not wiped. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146FsnrtqFd6RhsnrEDf7Fy
…ion on enter Previously the typed value only appeared as an option when nothing matched, and pressing enter always committed the raw typed text — even after arrowing to an option in the list. The typed value now always shows as an `Add "..."` option at the top of the list, and enter selects whichever option is highlighted. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146FsnrtqFd6RhsnrEDf7Fy
Only keyboard focus from outside the component opens it — pointer interactions leave opening to the trigger's own click handling, and focus returning from a dropdown item is ignored so selecting an option does not reopen it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146FsnrtqFd6RhsnrEDf7Fy
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146FsnrtqFd6RhsnrEDf7Fy
`defineExpose` unwraps refs, so `searchQuery.value` was `undefined` and `hasUnfinishedParameters` threw inside the `added` handler. Previously the rule had already been added by the time the error was swallowed; now `added` is emitted before the selection lands, so the throw aborted it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146FsnrtqFd6RhsnrEDf7Fy
duncanmcclean
marked this pull request as ready for review
August 24, 2026 13:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the UX of taggable comboboxes.
Add "..."option at the top of the dropdown, alongside any matching options, rather than only when nothing matched. Since typing highlights the first option, it's always clear what pressing enter will do.defineExposeunwraps refs, so the builder'saddedhandler was readingsearchQuery.valueasundefinedand throwing.This PR also renders the add option label in the relationship select and formatting locales fieldtypes, since they provide their own option templates.
Before
CleanShot.2026-08-24.at.14.50.51.mp4
After
CleanShot.2026-08-24.at.14.55.15.mp4