[6.x] Fix calendar view for date fields using a format without time - #15246
Open
duncanmcclean wants to merge 1 commit into
Open
[6.x] Fix calendar view for date fields using a format without time#15246duncanmcclean wants to merge 1 commit into
duncanmcclean wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VBYozYY2819GBNn5eMc67y
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where the calendar view for collections would break when the collection's date field uses a
formatwithout a time component, likeY-m-d. The calendar would render for a moment, then everything apart from the weekday header row would disappear (or, depending on the build, entries would simply never show).This was happening because when a date field's format has no time,
preProcessIndexreturns a plainY-m-dstring rather than a full ISO 8601 datetime string. The calendar passed that straight intoparseAbsoluteToLocal, which throws for date-only strings, breaking the render.This PR fixes it by adding a
getEntryDatehelper which parses date-only values withparseDateand datetime values withparseAbsoluteToLocal. In the week view, date-only entries are shown against midnight. This PR also hides the time label on month view entries when the date format has no time, since it would otherwise show a meaningless, timezone-shifted midnight.Fixes #15245