Repository navigation
Conversation
Contributor
📈 Unit Test Coverage Delta vs Main Branch
|
Contributor
Unit Test Coverage Report
|
Contributor
📉 Integration Test Coverage Delta vs Main Branch (dse69-it)
|
Contributor
Integration Test Coverage Report (dse69-it)
|
Contributor
Integration Test Coverage Report (hcd-it)
|
Confirmed RED on main: 32 cases expose decimal truncation, integer overflow, or unhelpful overflow errors. Integer boundaries and omitted/null defaults still pass.
Confirmed RED for whole-valued decimals, exponent notation, and numeric strings alongside the numeric regressions. Added HTTP error mapping and positivity regression tests.
Confirmed GREEN: 104 parsing and HTTP tests pass. Limit values must be JSON integers fitting int32 before conversion, while defaults, positivity checks, and configured hybrid bounds are retained.
Confirmed RED: 5.0 and 5e0 produce messages displaying 5 without explaining that the input is floating point.
Confirmed GREEN: all 239 targeted tests pass, including HTTP checks explaining that 5.0 and 5e0 are floating-point inputs.
erichare
force-pushed
the
fix/find-and-rerank-integer-limits
branch
from
November 5, 2026 22:35
abaf2cf to
da87349
Compare
Contributor
📉 Integration Test Coverage Delta vs Main Branch (hcd-it)
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Requires limit and scalar or object hybridLimits values to be JSON integers within the Java integer range before conversion. Invalid values return REQUEST_STRUCTURE_MISMATCH with the field path and value. Null defaults, positivity checks, and configured hybrid bounds retain their existing behavior.
Which issue(s) this PR fixes:
Fixes #2610
Verification:
Passed on Java 21 with 242 tests, no failures, errors, or skips. Formatting and whitespace checks passed, including request-error and MCP schema contract coverage. Full unit and database integration suites were not run.
JAVA_HOME=/Library/Java/JavaVirtualMachines/graalvm-21.jdk/Contents/Home ./mvnw clean fmt:check -Dtest=FindAndRerankCommandLimitsTest,FindAndRerankLimitsTest,HybridLimitsDeserializerTest,FindAndRerankPlannerTest,FindAndRerankOperationBuilderTest,McpClauseSchemaContractTest test git diff --check cca16839af848aa3bed8f34d02845f5eb8123511...HEADChecklist