Skip to content

stan_csv_reader: avoid infinite loops on poorly placed EOF - #3428

Open
WardBrian wants to merge 1 commit into
developfrom
fix/3426-csv-reader-avoid-inf-loop-eol
Open

stan_csv_reader: avoid infinite loops on poorly placed EOF#3428
WardBrian wants to merge 1 commit into
developfrom
fix/3426-csv-reader-avoid-inf-loop-eol

Conversation

@WardBrian

Copy link
Copy Markdown
Member

Submission Checklist

  • Run unit tests: ./runTests.py src/test/unit
  • Run cpplint: make cpplint
  • Declare copyright holder and open-source license: see below

Summary

Closes #3426. While this can only be triggered by an invalid file, it is still better to not loop forever.

Intended Effect

How to Verify

Side Effects

Documentation

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

stan_csv_reader hangs forever on a truncated CSV with saved warmup

2 participants