Fix loo_compare() for subsampling results - #391
Open
florence-bockting wants to merge 5 commits into
Open
Conversation
…for subsampled loo objects
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #391 +/- ##
=======================================
Coverage 92.86% 92.86%
=======================================
Files 31 31
Lines 3041 3041
=======================================
Hits 2824 2824
Misses 217 217 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 8635a88 is merged into master:
|
florence-bockting
marked this pull request as ready for review
September 3, 2026 06:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #390
Description
loo_comparefor subsampling results provided a difference based on reference model - comparison model, whileloo_comparefor other loo objects returned the reverse difference leading to a flip in the sign ofelpd_diff.This PR fixes the sign flip, adds a test for the comparison direction, and updates the related outputs of the tutorial
vignettes/loo2-large-data.Rmd.Tests
test_loo_subsampling.R: [ FAIL 0 | WARN 0 | SKIP 0 | PASS 408 ]Documentation
Updated the three printed tables in
loo2-large-data.Rmd.TODO
devtools::check()NEWS.mdAI assistance
I used AI assistance while working on this PR. I have reviewed all changes.